Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3886 and #3887: drop remaining KitKat TODOs. #5018

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Jun 5, 2023

Explanation

This PR fixes #3886 and fixes #3887 by dropping TODOs for those obsolete issues so that they can be fully closed.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@seanlip seanlip requested a review from a team as a code owner June 5, 2023 09:56
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@adhiamboperes adhiamboperes merged commit f727c06 into develop Jun 5, 2023
40 checks passed
@adhiamboperes adhiamboperes deleted the drop-todos branch June 5, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Glide drawable native crash on KitKat Add Proguard support to oppia_alpha_kitkat
2 participants