Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #23: Topic Tab Icons updated #505

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Fix part of #23: Topic Tab Icons updated #505

merged 4 commits into from
Dec 3, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Dec 2, 2019

Explanation

Topic Tabs updated icons:

Screenshot 2019-12-03 at 12 48 52 AM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 2, 2019

@mschanteltc These icons are way better, but I still think that topic-train icon is comparatively smaller than others, can we fix that?

Thanks.

@mschanteltc
Copy link

@rt4914 I updated the train icon so that the height and width are equal. All the other icons LGTM.

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 2, 2019

@rt4914 I updated the train icon so that the height and width are equal. All the other icons LGTM.

Yeah, the updated train icon looks perfect. Check description for screenshot.

@mschanteltc
Copy link

It seems that the stroke width of the train icon makes the set of icons appear inconsistent. I updated the train icon again with a different brain image and omitted the weight. Can you update the mock with this new icon please?

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 2, 2019

It seems that the stroke width of the train icon makes the set of icons appear inconsistent. I updated the train icon again with a different brain image and omitted the weight. Can you update the mock with this new icon please?

Check this @mschanteltc
Screenshot 2019-12-03 at 1 21 00 AM

@mschanteltc
Copy link

Looks good! One last thing is to make sure the sizing of icons fits the Material Guidelines. I updated the Review Icon to follow these standards, so please update this on mocks.

Overview, Play, and Train icons (circle icons):

  • Height: 20 dp

  • Width: 20 dp

Review icon (vertical rectangle icon):

  • Height: 20 dp

  • Width: 16 dp

Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks good to me please address @mschanteltc's suggestions and assign me back.

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 3, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 3, 2019

Looks good! One last thing is to make sure the sizing of icons fits the Material Guidelines. I updated the Review Icon to follow these standards, so please update this on mocks.

Overview, Play, and Train icons (circle icons):

  • Height: 20 dp
  • Width: 20 dp

Review icon (vertical rectangle icon):

  • Height: 20 dp
  • Width: 16 dp

Used all latest icons from the drive.

Result:
Screenshot 2019-12-03 at 1 21 00 AM

Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 3, 2019
@rt4914 rt4914 merged commit 1813ccf into develop Dec 3, 2019
@rt4914 rt4914 deleted the topic-tab-icons branch December 3, 2019 15:20
@mschanteltc
Copy link

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants