Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #494: Audio autoplay issue fix #515

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Dec 4, 2019

Explanation

The audio should be auto playable on changing the states. This PR fixes the inconsistency issue in that.
Also, checking this was hard because there can be various scenarios to test this, so make sure you test this in various conditions, for example:

  1. Play audio and change state in between.
  2. Pause Audio and change state in between.
  3. Play audio, submit answer and then change state in between.
    or create your own scenarios.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@BenHenning BenHenning merged commit 331fda3 into temp-integration-pt3 Dec 4, 2019
@BenHenning BenHenning deleted the audio-auto-play-fix branch December 4, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants