Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding for scroll view in concept card #518

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

BenHenning
Copy link
Sponsor Member

I'm not sure why there was padding at the bottom of the concept card, but it causes the text to look weird/get cut off on smaller screens or with text zoom:

image

@BenHenning BenHenning changed the title Remove padding for scroll view in concept card. Remove padding for scroll view in concept card Dec 5, 2019
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe this similar padding will be in other screens too. So will check this on other devices to make sure that the padding does not create any unexpected behaviour.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Dec 5, 2019
@BenHenning
Copy link
Sponsor Member Author

Thanks @rt4914! Please let me know if you notice any issues.

@BenHenning BenHenning merged commit c781c9b into develop Dec 5, 2019
@BenHenning BenHenning deleted the fix-concept-card-spacing branch December 5, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants