-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4362, #1491: When reading text size is extra large, resume lesson page and revision tabs content is seen in normal size #5290
Draft
Vishwajith-Shettigar
wants to merge
62
commits into
oppia:develop
Choose a base branch
from
Vishwajith-Shettigar:readingsize
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
d4c9168
fixed reading text size for lesson activity
Vishwajith-Shettigar e46ca6b
fixed reading text size for lesson activity
Vishwajith-Shettigar 380562b
fixed reading text size for lesson activity
Vishwajith-Shettigar 8386f62
fixed reading text size for lesson activity
Vishwajith-Shettigar a158e5f
fixed reading text size for lesson activity
Vishwajith-Shettigar 1074505
fixed reading text size for revision
Vishwajith-Shettigar 3c83b32
fixed reading text size for revision
Vishwajith-Shettigar e5ba6c3
set reading text size medium for revision option items
Vishwajith-Shettigar e393543
lint issue fix
Vishwajith-Shettigar 7e634ad
lint issue fix
Vishwajith-Shettigar 35a9b51
fix lint issue
Vishwajith-Shettigar 7afe5a9
tool bar title size fixed
Vishwajith-Shettigar 932d7a2
kdoc added
Vishwajith-Shettigar 46c5ed0
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 5435338
Merge branch 'develop' into readingsize
Vishwajith-Shettigar da66a27
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 8e6e686
Merge branch 'develop' into readingsize
Vishwajith-Shettigar c5a0431
Merge branch 'develop' into readingsize
Vishwajith-Shettigar f420536
addressed comments
Vishwajith-Shettigar 907654b
addressed comments
Vishwajith-Shettigar 033ab60
Merge branch 'develop' into readingsize
Vishwajith-Shettigar fe9a1d9
added tests for reumelesson fragment
Vishwajith-Shettigar 7c8183b
added tests for reumelesson fragment
Vishwajith-Shettigar a84d759
test modified
Vishwajith-Shettigar caaf2c7
tests added for revision card fragment
Vishwajith-Shettigar d070084
tests fixed
Vishwajith-Shettigar e6d36b1
tests fixed
Vishwajith-Shettigar c1eacd4
Merge branch 'develop' into readingsize
Vishwajith-Shettigar c3321d1
tests fixed
Vishwajith-Shettigar dbd3528
refinied
Vishwajith-Shettigar 9b6444d
Merge branch 'develop' into readingsize
Vishwajith-Shettigar a434c3e
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 749f58a
Merge branch 'develop' into readingsize
Vishwajith-Shettigar f2fc42f
addressed comments
Vishwajith-Shettigar 20c80e2
fix klint
Vishwajith-Shettigar 693b39a
Delete hs_err_pid7956.log
Vishwajith-Shettigar 1087154
addressed comments
Vishwajith-Shettigar 5ccabef
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 28b1b5c
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 4306527
support text scaling question player
Vishwajith-Shettigar fef59c7
clean up
Vishwajith-Shettigar 0de4260
Merge branch 'develop' into readingsize
Vishwajith-Shettigar 4e473c6
test fix
Vishwajith-Shettigar c723f4c
test fix
Vishwajith-Shettigar 58a1055
tests fix
Vishwajith-Shettigar 9088d30
tests fix
Vishwajith-Shettigar b68b6fc
tests added for question player
Vishwajith-Shettigar 8d5c612
tests fix
Vishwajith-Shettigar cc7bf87
tests fixed
Vishwajith-Shettigar 45b38ef
test changes
Vishwajith-Shettigar 45df691
klint
Vishwajith-Shettigar 6b8a9a8
test changes
Vishwajith-Shettigar e197107
fix
Vishwajith-Shettigar 27f077f
marks test as flaky
Vishwajith-Shettigar ce57386
mark test as flaky
Vishwajith-Shettigar 1d15e3e
Resolved conflicts
Vishwajith-Shettigar 1b05539
Fixed tests for QuestionPLayerActivity
Vishwajith-Shettigar 4f6f050
klint
Vishwajith-Shettigar ff7f685
Rename verify font size method
Vishwajith-Shettigar 731d03e
Fixed unresolved reference
Vishwajith-Shettigar 0a45fbb
Merge branch 'develop' into readingsize
Vishwajith-Shettigar c03807d
Merge branch 'develop' into readingsize
Vishwajith-Shettigar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is no need to reset the size here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't set text size medium it will affect the exploration tool bar title text size.
Resume.webm