Fix Part of #4938: Introduce Onboarding profile type screen [Blocked: #5373] #5378

adhiamboperes · 2024-04-03T15:55:38Z

Explanation

Fixes Part of #4938: Introduce Onboarding profile type screen

Adds the profile type selection screen.

The new "I am a student" flow is not implemented, and tests have been set up to fail when the flow has been implemented.

The "I am a parent/teacher" flow has been set up to route to the existing profile screen.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

All tests pass on Espresso

For UI-specific PRs only


	Portrait	Landscape
Mobile Light Mode
Mobile Dark Mode
Tablet Light Mode
Tablet Dark Mode

…boarding-profile-type-screen

…boarding-profile-type-screen # Conflicts: # app/src/main/res/values/component_colors.xml # scripts/assets/test_file_exemptions.textproto

adhiamboperes

Self- review pass

app/src/main/AndroidManifest.xml

app/src/main/java/org/oppia/android/app/onboardingv2/OnboardingProfileTypeFragmentPresenter.kt

app/src/main/java/org/oppia/android/app/onboardingv2/OnboardingFragmentPresenter.kt

…d into onboarding-profile-type-screen

BenHenning

Thanks @adhiamboperes! Had a few comments--PTAL.

Also per my review of the blocking PR, I wonder if we could just keep everything under onboarding/ rather than having a separate package. WDYT?

BenHenning · 2024-05-26T01:10:47Z

app/src/main/res/drawable/learner_otter.png

For this & the other PNG--can these also be SVGs, instead?

For these specific images, we do not have svg versions.

I wonder if they have source materials (e.g. Illustrator) that can be used to export SVG versions. The concern with using PNGs (aside from the binary implications in the repository) is that they won't scale correctly for different display resolutions without introducing multiple copies of the PNGs. SVGs scale arbitrarily and should always look correct.

app/src/main/res/values/strings.xml

app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentTest.kt

oppiabot · 2024-05-26T01:23:37Z

Hi, @adhiamboperes, the LGTM Label has been removed because the changes were requested on this PR. Thanks!.

oppiabot · 2024-06-02T02:07:39Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

…boarding-profile-type-screen # Conflicts: # app/src/main/java/org/oppia/android/app/activity/ActivityComponentImpl.kt # app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragment.kt # app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt # scripts/assets/test_file_exemptions.textproto

adhiamboperes · 2024-06-04T10:02:03Z

@BenHenning, PTAL.

oppiabot · 2024-06-11T10:44:23Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

github-actions · 2024-06-13T04:05:22Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 17 MiB (old), 17 MiB (new), 96 KiB (Added)

APK download size (estimated): 16 MiB (old), 16 MiB (new), 90 KiB (Added)

Method count: 235368 (old), 235511 (new), 143 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6550 (old), 6587 (new), 37 (Added)

Anim: 49 (old), 49 (new), 0 (No change)
Animator: 20 (old), 20 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 915 (old), 915 (new), 0 (No change)
Bool: 10 (old), 10 (new), 0 (No change)
Color: 911 (old), 915 (new), 4 (Added):
- color/color_def_survey_disabled_button_grey (removed)
- color/color_def_dark_jade (added)
- color/color_def_disabled_button_grey (added)
- color/color_def_jade (added)
- color/color_palette_onboarding_profile_type_background_color (added)
- And 1 other
Dimen: 994 (old), 995 (new), 1 (Added):
- dimen/onboarding_shared_padding_medium (added)
Drawable: 373 (old), 376 (new), 3 (Added):
- drawable/learner_otter (added)
- drawable/onboarding_back_button_white_background (added)
- drawable/parent_teacher_otter (added)
Id: 1206 (old), 1219 (new), 13 (Added):
- id/onboarding_navigation_back (added)
- id/onboarding_profile_type_background (added)
- id/onboarding_steps_count (added)
- id/profile_type_center_guide (added)
- id/profile_type_fragment_placeholder (added)
- And 8 others
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 368 (old), 370 (new), 2 (Added):
- layout/onboarding_profile_type_activity (added)
- layout/onboarding_profile_type_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 805 (old), 814 (new), 9 (Added):
- string/onboarding_learner_otter_content_description (added)
- string/onboarding_navigation_back (added)
- string/onboarding_navigation_continue (added)
- string/onboarding_parent_otter_content_description (added)
- string/onboarding_profile_type_activity_header (added)
- And 4 others
Style: 816 (old), 821 (new), 5 (Added):
- style/OnboardingNavigationSecondaryButton (added)
- style/OnboardingProfileTypeHeaderStyle (added)
- style/OnboardingProfileTypeHeaderStyleLandscape (added)
- style/OnboardingProfileTypeNavigationCardStyle (added)
- style/OnboardingProfileTypeTextStyle (added)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 17 MiB (old), 17 MiB (new), 95 KiB (Added)
APK download size (estimated): 15 MiB (old), 15 MiB (new), 86 KiB (Added)
Method count: 235368 (old), 235511 (new), 143 (Added)
Resources: 6485 (old), 6522 (new), 37 (Added)

Color: 911 (old), 915 (new), 4 (Added)
Dimen: 989 (old), 990 (new), 1 (Added)
Drawable: 314 (old), 317 (new), 3 (Added)
Id: 1206 (old), 1219 (new), 13 (Added)
Layout: 368 (old), 370 (new), 2 (Added)
String: 805 (old), 814 (new), 9 (Added)
Style: 816 (old), 821 (new), 5 (Added)

Configuration hdpi

APK file size: 59 KiB (old), 59 KiB (new), 28 bytes (Added)
APK download size (estimated): 23 KiB (old), 23 KiB (new), 5 bytes (Added)

Configuration ldpi

APK file size: 56 KiB (old), 56 KiB (new), 36 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 3 bytes (Added)

Configuration mdpi

APK file size: 53 KiB (old), 53 KiB (new), 32 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration tvdpi

APK file size: 103 KiB (old), 103 KiB (new), 48 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 5 bytes (Added)

Configuration xhdpi

APK file size: 67 KiB (old), 67 KiB (new), 32 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 4 bytes (Added)

Configuration xxhdpi

APK file size: 76 KiB (old), 76 KiB (new), 32 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 2 bytes (Added)

Configuration xxxhdpi

APK file size: 79 KiB (old), 79 KiB (new), 36 bytes (Added)
APK download size (estimated): 39 KiB (old), 39 KiB (new), 2 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 91 KiB (Added)

APK download size (estimated): 9044 KiB (old), 9130 KiB (new), 85 KiB (Added)

Method count: 93608 (old), 93698 (new), 90 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5540 (new), 36 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 771 (new), 4 (Added):
- color/color_def_dark_jade (added)
- color/color_def_jade (added)
- color/color_palette_onboarding_profile_type_background_color (added)
- color/component_color_onboarding_profile_type_background_color (added)
Dimen: 722 (old), 723 (new), 1 (Added):
- dimen/onboarding_shared_padding_medium (added)
Drawable: 333 (old), 336 (new), 3 (Added):
- drawable/learner_otter (added)
- drawable/onboarding_back_button_white_background (added)
- drawable/parent_teacher_otter (added)
Id: 1148 (old), 1161 (new), 13 (Added):
- id/onboarding_navigation_back (added)
- id/onboarding_profile_type_background (added)
- id/onboarding_steps_count (added)
- id/profile_type_center_guide (added)
- id/profile_type_fragment_placeholder (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 329 (new), 2 (Added):
- layout/onboarding_profile_type_activity (added)
- layout/onboarding_profile_type_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 744 (new), 8 (Added):
- string/onboarding_learner_otter_content_description (added)
- string/onboarding_navigation_back (added)
- string/onboarding_parent_otter_content_description (added)
- string/onboarding_profile_type_activity_header (added)
- string/onboarding_profile_type_activity_parent_text (added)
- And 3 others
Style: 457 (old), 462 (new), 5 (Added):
- style/OnboardingNavigationSecondaryButton (added)
- style/OnboardingProfileTypeHeaderStyle (added)
- style/OnboardingProfileTypeHeaderStyleLandscape (added)
- style/OnboardingProfileTypeNavigationCardStyle (added)
- style/OnboardingProfileTypeTextStyle (added)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 90 KiB (Added)
APK download size (estimated): 8930 KiB (old), 9012 KiB (new), 82 KiB (Added)
Method count: 93608 (old), 93698 (new), 90 (Added)
Resources: 5446 (old), 5482 (new), 36 (Added)

Color: 767 (old), 771 (new), 4 (Added)
Dimen: 719 (old), 720 (new), 1 (Added)
Drawable: 279 (old), 282 (new), 3 (Added)
Id: 1148 (old), 1161 (new), 13 (Added)
Layout: 327 (old), 329 (new), 2 (Added)
String: 736 (old), 744 (new), 8 (Added)
Style: 457 (old), 462 (new), 5 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 12 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 5 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 20 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 12 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 20 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 6 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 16 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 3 bytes (Added)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 12 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 12 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 3 bytes (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 91 KiB (Added)

APK download size (estimated): 9032 KiB (old), 9116 KiB (new), 83 KiB (Added)

Method count: 93608 (old), 93698 (new), 90 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5540 (new), 36 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 771 (new), 4 (Added):
- color/color_def_dark_jade (added)
- color/color_def_jade (added)
- color/color_palette_onboarding_profile_type_background_color (added)
- color/component_color_onboarding_profile_type_background_color (added)
Dimen: 722 (old), 723 (new), 1 (Added):
- dimen/onboarding_shared_padding_medium (added)
Drawable: 333 (old), 336 (new), 3 (Added):
- drawable/learner_otter (added)
- drawable/onboarding_back_button_white_background (added)
- drawable/parent_teacher_otter (added)
Id: 1148 (old), 1161 (new), 13 (Added):
- id/onboarding_navigation_back (added)
- id/onboarding_profile_type_background (added)
- id/onboarding_steps_count (added)
- id/profile_type_center_guide (added)
- id/profile_type_fragment_placeholder (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 329 (new), 2 (Added):
- layout/onboarding_profile_type_activity (added)
- layout/onboarding_profile_type_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 744 (new), 8 (Added):
- string/onboarding_learner_otter_content_description (added)
- string/onboarding_navigation_back (added)
- string/onboarding_parent_otter_content_description (added)
- string/onboarding_profile_type_activity_header (added)
- string/onboarding_profile_type_activity_parent_text (added)
- And 3 others
Style: 457 (old), 462 (new), 5 (Added):
- style/OnboardingNavigationSecondaryButton (added)
- style/OnboardingProfileTypeHeaderStyle (added)
- style/OnboardingProfileTypeHeaderStyleLandscape (added)
- style/OnboardingProfileTypeNavigationCardStyle (added)
- style/OnboardingProfileTypeTextStyle (added)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 90 KiB (Added)
APK download size (estimated): 8915 KiB (old), 9001 KiB (new), 86 KiB (Added)
Method count: 93608 (old), 93698 (new), 90 (Added)
Resources: 5446 (old), 5482 (new), 36 (Added)

Color: 767 (old), 771 (new), 4 (Added)
Dimen: 719 (old), 720 (new), 1 (Added)
Drawable: 279 (old), 282 (new), 3 (Added)
Id: 1148 (old), 1161 (new), 13 (Added)
Layout: 327 (old), 329 (new), 2 (Added)
String: 736 (old), 744 (new), 8 (Added)
Style: 457 (old), 462 (new), 5 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 12 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 4 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 20 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 4 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 12 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 2 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 20 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 6 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 16 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 3 bytes (Added)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 12 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 12 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 2 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 9 MiB (old), 9 MiB (new), 90 KiB (Added)

APK download size (estimated): 9032 KiB (old), 9116 KiB (new), 84 KiB (Added)

Method count: 93608 (old), 93698 (new), 90 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5504 (old), 5540 (new), 36 (Added)

Anim: 39 (old), 39 (new), 0 (No change)
Animator: 18 (old), 18 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 879 (old), 879 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 767 (old), 771 (new), 4 (Added):
- color/color_def_dark_jade (added)
- color/color_def_jade (added)
- color/color_palette_onboarding_profile_type_background_color (added)
- color/component_color_onboarding_profile_type_background_color (added)
Dimen: 722 (old), 723 (new), 1 (Added):
- dimen/onboarding_shared_padding_medium (added)
Drawable: 333 (old), 336 (new), 3 (Added):
- drawable/learner_otter (added)
- drawable/onboarding_back_button_white_background (added)
- drawable/parent_teacher_otter (added)
Id: 1148 (old), 1161 (new), 13 (Added):
- id/onboarding_navigation_back (added)
- id/onboarding_profile_type_background (added)
- id/onboarding_steps_count (added)
- id/profile_type_center_guide (added)
- id/profile_type_fragment_placeholder (added)
- And 8 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 327 (old), 329 (new), 2 (Added):
- layout/onboarding_profile_type_activity (added)
- layout/onboarding_profile_type_fragment (added)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 736 (old), 744 (new), 8 (Added):
- string/onboarding_learner_otter_content_description (added)
- string/onboarding_navigation_back (added)
- string/onboarding_parent_otter_content_description (added)
- string/onboarding_profile_type_activity_header (added)
- string/onboarding_profile_type_activity_parent_text (added)
- And 3 others
Style: 457 (old), 462 (new), 5 (Added):
- style/OnboardingNavigationSecondaryButton (added)
- style/OnboardingProfileTypeHeaderStyle (added)
- style/OnboardingProfileTypeHeaderStyleLandscape (added)
- style/OnboardingProfileTypeNavigationCardStyle (added)
- style/OnboardingProfileTypeTextStyle (added)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 105 (old), 105 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 9 MiB (old), 9 MiB (new), 90 KiB (Added)
APK download size (estimated): 8915 KiB (old), 9001 KiB (new), 86 KiB (Added)
Method count: 93608 (old), 93698 (new), 90 (Added)
Resources: 5446 (old), 5482 (new), 36 (Added)

Color: 767 (old), 771 (new), 4 (Added)
Dimen: 719 (old), 720 (new), 1 (Added)
Drawable: 279 (old), 282 (new), 3 (Added)
Id: 1148 (old), 1161 (new), 13 (Added)
Layout: 327 (old), 329 (new), 2 (Added)
String: 736 (old), 744 (new), 8 (Added)
Style: 457 (old), 462 (new), 5 (Added)

Configuration hdpi

APK file size: 52 KiB (old), 52 KiB (new), 12 bytes (Added)
APK download size (estimated): 22 KiB (old), 22 KiB (new), 4 bytes (Added)

Configuration ldpi

APK file size: 52 KiB (old), 52 KiB (new), 20 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 3 bytes (Added)

Configuration mdpi

APK file size: 46 KiB (old), 46 KiB (new), 12 bytes (Added)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 4 bytes (Added)

Configuration tvdpi

APK file size: 90 KiB (old), 90 KiB (new), 20 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 6 bytes (Added)

Configuration xhdpi

APK file size: 60 KiB (old), 60 KiB (new), 16 bytes (Added)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 3 bytes (Added)

Configuration xxhdpi

APK file size: 69 KiB (old), 69 KiB (new), 12 bytes (Added)
APK download size (estimated): 37 KiB (old), 37 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 71 KiB (old), 71 KiB (new), 12 bytes (Added)
APK download size (estimated): 38 KiB (old), 38 KiB (new), 2 bytes (Removed)

BenHenning

Thanks @adhiamboperes! Mostly LGTM, but had a few comments--PTAL.

BenHenning · 2024-06-14T18:59:01Z

app/src/main/res/layout-land/onboarding_profile_type_fragment.xml

+      app:customBackgroundColor="@{@color/component_color_onboarding_profile_type_background_color}"
+      app:layout_constraintTop_toBottomOf="@id/profile_type_center_guide" />
+
+    <androidx.constraintlayout.widget.ConstraintLayout


Can this be flattened? I think most (all?) nested ConstraintLayouts should theoretically be simplifiable (except when separated by a non-constraint layout like MaterialCardView below).

BenHenning · 2024-06-14T19:02:06Z

app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentTest.kt

+    }
+  }
+
+  @RunOn(TestPlatform.ESPRESSO) // Testing lifecycle fails on Robolectric.


Alternatively, you could verify that the activity is finishing using Activity.isFinishing() which I think is Robolectric-friendly.

app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentTest.kt

BenHenning · 2024-06-14T19:08:44Z

app/src/main/res/drawable/learner_otter.png

I wonder if they have source materials (e.g. Illustrator) that can be used to export SVG versions. The concern with using PNGs (aside from the binary implications in the repository) is that they won't scale correctly for different display resolutions without introducing multiple copies of the PNGs. SVGs scale arbitrarily and should always look correct.

adhiamboperes added 8 commits April 3, 2024 01:45

Merge remote-tracking branch 'upstream/new-onboarding-screen' into on…

a337b9b

…boarding-profile-type-screen

Add OnboardingProfileTypeActivity

785716e

Add drawable resources

3067ff2

Add profile type selection UI with navigation.

5a41256

Add tests

40d188f

Add test file exemptions

434d9dc

Fix ktlint issue

5bd5239

Merge remote-tracking branch 'upstream/new-onboarding-screen' into on…

3d2313c

…boarding-profile-type-screen # Conflicts: # app/src/main/res/values/component_colors.xml # scripts/assets/test_file_exemptions.textproto

adhiamboperes self-assigned this Apr 3, 2024

adhiamboperes commented Apr 3, 2024

View reviewed changes

adhiamboperes added 4 commits April 9, 2024 07:46

Fix self review comments

6ccba79

Create tablet layouts and darkmode bg

f31e23d

Merge branch 'new-onboarding-screen' of github.com:oppia/oppia-androi…

3e6c7b3

…d into onboarding-profile-type-screen

Fix formatting

f1d9092

adhiamboperes marked this pull request as ready for review April 9, 2024 13:22

adhiamboperes requested review from a team as code owners April 9, 2024 13:22

adhiamboperes requested review from BenHenning and theMr17 and removed request for a team and BenHenning April 9, 2024 13:22

adhiamboperes assigned XichengSpencer and theMr17 and unassigned adhiamboperes Apr 9, 2024

adhiamboperes requested a review from XichengSpencer April 9, 2024 13:22

adhiamboperes removed their assignment May 24, 2024

BenHenning changed the title ~~Fix Part of #4938: Introduce Onboarding profile type screen~~ Fix Part of #4938: Introduce Onboarding profile type screen [Blocked: #5373] May 26, 2024

BenHenning requested changes May 26, 2024

View reviewed changes

BenHenning assigned adhiamboperes and unassigned BenHenning May 26, 2024

oppiabot bot removed the PR: LGTM label May 26, 2024

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 2, 2024

adhiamboperes unassigned XichengSpencer Jun 3, 2024

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 3, 2024

adhiamboperes added 7 commits June 3, 2024 20:40

Move files to onboarding package

3bf91c3

Resolve merge conflicts

05d05f1

Added oxford comma

1067e57

Removed leftover exemption

e79b69b

Fix tests

c694f51

Fix static check errors

12fbcad

adhiamboperes assigned BenHenning and unassigned adhiamboperes Jun 4, 2024

oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Jun 11, 2024

adhiamboperes added 2 commits June 11, 2024 17:03

Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen

ea056af

Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen

c2c244b

BenHenning requested changes Jun 14, 2024

View reviewed changes

BenHenning assigned adhiamboperes and unassigned BenHenning Jun 14, 2024

Fix Part of #4938: Introduce Onboarding profile type screen [Blocked: #5373] #5378

Are you sure you want to change the base?

Fix Part of #4938: Introduce Onboarding profile type screen [Blocked: #5373] #5378

Conversation

adhiamboperes commented Apr 3, 2024 • edited

Explanation

Essential Checklist

For UI-specific PRs only

adhiamboperes left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning May 26, 2024

Choose a reason for hiding this comment

adhiamboperes Jun 3, 2024

Choose a reason for hiding this comment

BenHenning Jun 14, 2024

Choose a reason for hiding this comment

oppiabot bot commented May 26, 2024

oppiabot bot commented Jun 2, 2024

adhiamboperes commented Jun 4, 2024

oppiabot bot commented Jun 11, 2024

github-actions bot commented Jun 13, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning Jun 14, 2024

Choose a reason for hiding this comment

BenHenning Jun 14, 2024

Choose a reason for hiding this comment

BenHenning Jun 14, 2024

Choose a reason for hiding this comment

adhiamboperes commented Apr 3, 2024 •

edited