-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4938: Introduce Create profile screen [Blocked: #5378] #5380
base: onboarding-profile-type-screen
Are you sure you want to change the base?
Fix Part of #4938: Introduce Create profile screen [Blocked: #5378] #5380
Conversation
…' into create-profile-screen # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/android/app/onboardingv2/OnboardingProfileTypeFragmentPresenter.kt # app/src/main/res/values-night/color_palette.xml
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
# Conflicts: # app/src/main/res/values/styles.xml # app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentTest.kt
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adhiamboperes. Approving to unblock the PR, but re: the mocks it does look a bit rough I think. Also, reminder to remove the 'blocked' part of your title before merging this into develop. :)
@seanlip do you have any thoughts on the "tap here to add a picture" portion of the screenshots in the PR description (or the mocks linked above)? I'm wondering if we can maybe soften the borders a bit so that there isn't such an abrupt edge between the text background and the profile image layered underneath it.
Another option might be to drop the help text and use a spotlight to teach the user that it's there.
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
@BenHenning Thanks for flagging. I took a look at the mocks and it seems that the UI here matches what's provided in the mocks. I'll bring this up with the design team and ask if any changes should be made, but I think it's still worth merging this PR now and doing that as a small fix-up later if we decide to change it. |
A quick update -- I did chat with the design team about this. They have a short-term suggestion and a long-term suggestion.
One other concern was i18n -- in German, for example, the text would be "Tippen Sie hier, um ein Bild hinzuzufügen" which is somewhat longer. Dropping the rectangle would probably help with that, too. Please let me know what you think @adhiamboperes @BenHenning. Thanks! (Also /cc designers @ashley-ya and @malee04 who were part of this discussion.) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
Thanks much @seanlip, @ashley-ya, and @malee04! I really appreciate the quick turnaround. Just to check, when you say "make the background a bit more transparent" which background is that referring to? @adhiamboperes do you have any thoughts on the short-term suggestion above? Do you think it's feasible & worth trying to incorporate here, or in a follow-up? FWIW I lean toward trying to do it here if the lift is small. |
By "background" I mean the part behind the text, i.e. the white/yellow picture (also, by "transparent" I just mean lighter). This is mostly a thought from me and is optional if the black text on top of the picture has sufficient contrast to be read clearly. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
# Conflicts: # scripts/assets/test_file_exemptions.textproto
@seanlip, @ashley-ya, and @malee04!, @BenHenning, Here are some attempts to incorporate the feedback. Could you please let me know which direction to lean towards?
|
Thanks @adhiamboperes! Personally, I like the second one best (highest contrast), followed by the third one, followed by the first. @ashley-ya @malee04 @BenHenning WDYT? |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
4 similar comments
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
Explanation
Fix Part of #4938: Add a new Activity and associated Fragments and Presenters to allow a new learner to create a profile.
This does not include domain changes.
Placeholder tests have been added to ensure navigation tests are not forgotten. These will fail once navigation has been implemented.
Essential Checklist
For UI-specific PRs only
All Tests Passing on Espresso