updated DSAdmin page for Docker #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note!!Merge after PR#20425 in Oppia gets merged. |
Co-authored-by: Sean Lip <sean@seanlip.org>
|
@seanlip Updated with required changed!! |
seanlip
approved these changes
Jun 8, 2024
|
Thanks! I will merge once other PR gets merged.
…On Sat, Jun 8, 2024 at 8:33 PM Sean Lip ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks, LGTM! Merge whenever you like :)
—
Reply to this email directly, view it on GitHub
<#330 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWL2L6J6436K6XEAWNPE4ALZGMMMLAVCNFSM6AAAAABJAA5GN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBVHA3DKMRVGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
@jayam04 This has been open for 2 weeks, are we planning to merge it? |
|
The PR for changes is not yet merged, but we can merge this if you want as
main PR needs final review.
…On Fri, Jun 21, 2024 at 2:08 PM Sean Lip ***@***.***> wrote:
@jayam04 <https://github.com/jayam04> This has been open for 2 weeks, are
we planning to merge it?
—
Reply to this email directly, view it on GitHub
<#330 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWL2L6NCTLHB6GBPJYUXMADZIPQ63AVCNFSM6AAAAABJAA5GN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGI4DGOBVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jayam04 Ah -- no, I think we should get the other PR merged so that this page is correct and we don't confuse contributors. What's blocking the other PR, can we get that in soon? |
5 tasks
|
@seanlip, this PR can be merged now. |
|
@U8NWXD Can you please commit this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Instructions to run DSAdmin in Docker Setup.