Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Part of #331: Moved Pre-requisites before Installation in Docker Installation #332

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jayam04
Copy link
Contributor

@jayam04 jayam04 commented Jun 22, 2024

Fixed part of #331
Moved Pre-requisites section above Installation section, well because it's better that way.

@jayam04
Copy link
Contributor Author

jayam04 commented Jun 22, 2024

@seanlip PTAL

@jayam04
Copy link
Contributor Author

jayam04 commented Jun 27, 2024

@seanlip PTAL

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jayam04. There seems to be quite a bit more in this PR than what was stated in the description; can you update the description?

Also I left a comment, PTAL, thanks.


Usage - `make run_tests.acceptance PYTHON_ARGS="--flag_name"`
* `--skip-build` - Skips building files.
* `--prod_env` - Runs tests in production mode.
* `--prod_env` - Run acceptance test in mobile viewport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense, was this change intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants