-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken image of author at "subscriptions" Tab #13454
Comments
@oppia/lace-team Please take a look. Thanks! |
The users "test" and "thomas" have no profile pictures and therefore do not have icons. This works fine for users with a profile picture. Noting that this is not a regression in the July release. |
Okay, makes sense, it would still be nice to have some prettier UI when the users do not have a profile picture. I have a refactor for profile pictures planned, but that probably won't be done in next 2 months. |
Don't all users have profile pictures (at least a gravatar)? If not we should probably populate for the older ones -- then it's easier to just treat everyone consistently. |
Yeah, that was basically the plan of my refactor, didn't get to it due to the unavailability of jobs. |
Describe the bug
Profile Image of the author of an exploration to which a learner subscribes looks broken at Subscription Tab on Learner's Dashboard
To Reproduce
Steps to reproduce the behavior:
1.Subscribe to an author
2. See behaviour at learner's dashboard
Observed behavior
A clear and concise description of what you have observed.
Chrome
Firefox
Expected behavior
Profile Image should show up
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information; delete this section if the issue does not arise on desktop):
Smartphone (please complete the following information; delete this section if the issue does not arise on smartphones):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: