Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image of author at "subscriptions" Tab #13454

Open
mridul-netizen opened this issue Jul 22, 2021 · 5 comments
Open

Broken image of author at "subscriptions" Tab #13454

mridul-netizen opened this issue Jul 22, 2021 · 5 comments
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@mridul-netizen
Copy link
Contributor

Describe the bug
Profile Image of the author of an exploration to which a learner subscribes looks broken at Subscription Tab on Learner's Dashboard
To Reproduce
Steps to reproduce the behavior:
1.Subscribe to an author
2. See behaviour at learner's dashboard

Observed behavior
A clear and concise description of what you have observed.
Chrome
image

Firefox

image

Expected behavior
Profile Image should show up
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information; delete this section if the issue does not arise on desktop):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Browser-version [e.g. 22]

Smartphone (please complete the following information; delete this section if the issue does not arise on smartphones):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Browser-version [e.g. 22]

Additional context
Add any other context about the problem here.

@mridul-netizen mridul-netizen added this to the Regressions (July 2021) milestone Jul 22, 2021
@rohitkatlaa
Copy link
Contributor

@oppia/lace-team Please take a look. Thanks!

@kevintab95
Copy link
Member

The users "test" and "thomas" have no profile pictures and therefore do not have icons. This works fine for users with a profile picture.
image

Noting that this is not a regression in the July release.
/cc @vojtechjelinek @rohitkatlaa

@kevintab95 kevintab95 removed this from the Regressions (July 2021) milestone Jul 31, 2021
@vojtechjelinek
Copy link
Member

Okay, makes sense, it would still be nice to have some prettier UI when the users do not have a profile picture. I have a refactor for profile pictures planned, but that probably won't be done in next 2 months.

@seanlip
Copy link
Member

seanlip commented Jul 31, 2021

Don't all users have profile pictures (at least a gravatar)? If not we should probably populate for the older ones -- then it's easier to just treat everyone consistently.

@vojtechjelinek
Copy link
Member

Yeah, that was basically the plan of my refactor, didn't get to it due to the unavailability of jobs.

@dchen97 dchen97 added this to Awaiting Triage in Learner and Creator Experience via automation Aug 4, 2021
@dchen97 dchen97 moved this from Awaiting Triage to General learner-facing pages (@donosco98) in Learner and Creator Experience Aug 4, 2021
@kevintab95 kevintab95 removed their assignment Nov 18, 2021
@kevintab95 kevintab95 added the bug Label to indicate an issue is a regression label Sep 1, 2022
@nithinrdy nithinrdy removed this from General learner-facing pages (@donosco98) in Learner and Creator Experience Sep 4, 2022
@Lawful2002 Lawful2002 added Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Dec 15, 2022
@aks681 aks681 removed their assignment Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

7 participants