New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes Material Icons with Font Awesome icons in these files #16797
Conversation
Hi @852hamza, can you complete the following:
|
Hi @nithinrdy, could you please add the appropriate changelog label to this pull request? Thanks! |
Hi @852hamza, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just one issue.
For each of the new check marks that you've added, could you please position them a little bit lower so that they properly align with the option text present next to them? Adding a bit of margin/padding should do the trick.
PTAL, Thanks!
Okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly review
Could you please add updated images after the changes? With the check mark now better aligned with the text? |
Hi @852hamza, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @852hamza, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @852hamza, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @852hamza, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @852hamza, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks! |
Hi @852hamza, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Overview
Essential Checklist
Proof that changes are correct
Before changes
After changes
2.oppia/core/templates/pages/learner-group-pages/create-group/add-syllabus-items.component.html
Before changes
After changes
Before changes
After changes
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers