Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'There are no contributions for the given time range.' error should be handled properly #19388

Closed
chris7716 opened this issue Dec 30, 2023 · 3 comments
Closed

'There are no contributions for the given time range.' error should be handled properly #19388

chris7716 opened this issue Dec 30, 2023 · 3 comments
Labels
Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@chris7716
Copy link
Contributor

Currently 'There are no contributions for the given time range.' is thrown as an internal server error. Modifying the function's signature to return ContributorCertificateInfo|None and have the caller handle the None case correctly would be the better solution.
@chris7716 chris7716 added Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Dec 30, 2023
@xoshiraghavx
Copy link

hey @chris7716 can you please share more details about this issue for better understanding?

@Ash-2k3
Copy link
Member

Ash-2k3 commented Apr 3, 2024

@chris7716 It maybe a duplicate of this #19264 ?

@seanlip seanlip mentioned this issue Apr 3, 2024
Closed
@seanlip
Copy link
Member

seanlip commented Apr 3, 2024

Agreed -- closing this in favour of #19264. Thanks @Ash-2k3!

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Contributor Experience Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanlip @chris7716 @xoshiraghavx @Ash-2k3