Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Enforce strict typescript checks on puppeteer acceptance tests. #20221

Open
jnvtnguyen opened this issue Apr 25, 2024 · 0 comments
Open

[Feature Request]: Enforce strict typescript checks on puppeteer acceptance tests. #20221

jnvtnguyen opened this issue Apr 25, 2024 · 0 comments
Labels
enhancement Label to indicate an issue is a feature/improvement

Comments

@jnvtnguyen
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Right now puppeteer acceptance tests are not strictly typescript checked since in tsconfig-strict we ignore all .spec.ts files.

Describe the solution (or solutions) you'd like

I expect puppeteer acceptance tests to be strictly typescript checked during the run_typescript_tests script in the CI or locally.

Describe alternatives you've considered and rejected

No response

Additional context

No response
@jnvtnguyen jnvtnguyen added triage needed enhancement Label to indicate an issue is a feature/improvement labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Label to indicate an issue is a feature/improvement
Projects
Developer Workflow Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanlip @jnvtnguyen