Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal properties of state object should be private. #6215

Open
DubeySandeep opened this issue Feb 6, 2019 · 1 comment
Open

Internal properties of state object should be private. #6215

DubeySandeep opened this issue Feb 6, 2019 · 1 comment
Labels
backend enhancement Label to indicate an issue is a feature/improvement Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@DubeySandeep
Copy link
Member

All over the test files the state objects are updated directly accessing the object's internal properties but from the top level, we use update_interaction_hints, update_interaction_answer_groups etc. to update the internal properties of the state, so making those internal properties private and updating the test file to follow a similar pattern would make a consitent and clean tests.

Note: Linking content_id to assets is managed internally and also from this perspective we expect all test to use a top-level method to update the internal properties such that they will go through updating assets with the content ids.

see this comment for reference.

@DubeySandeep DubeySandeep changed the title Internal property of state object should be private. Internal properties of state object should be private. Feb 6, 2019
@oppiabot
Copy link

oppiabot bot commented May 24, 2021

Hi @oppia/core-maintainers, this issue is not assigned to any project. Can you please update the same? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement Label to indicate an issue is a feature/improvement Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

2 participants