[Requires upgrade to CKEditor5] Spaces above images in the RTE should be deletable.

[seanlip]

Describe the bug
In RTEs, it seems impossible to delete the large vertical space above an image.

To Reproduce
Steps to reproduce the behavior:

1. Open the exploration editor.
2. Edit the content field to contain some text, followed by an image, followed by some text.
3. Delete the text before the image.
4. Try to delete the whitespace before the image.

Observed behavior
On pressing the Delete key, focus shifts to the image and the vertical space is not deleted.

Expected behavior
The vertical space above the image is deleted.

Screenshots

Before pressing Delete key:

After pressing Delete key:

Desktop (please complete the following information; delete this section if the issue does not arise on desktop):

• OS: Ubuntu Linux
• Browser: Chromium
• Version: 71.0

[seanlip]

/cc @bansalnitish

[bansalnitish]

Thanks for reporting this issue @seanlip . I'll try to fix this.

[bansalnitish]

I investigated and found that the issue is reproducible in CKEditor - 4.9.2 itself. The link for its demo -- https://ckeditor.com/ckeditor-4/demo/.

Though, it has been fixed in CKEditor5 :). The link for its demo -- https://ckeditor.com/ckeditor-5/demo/.

So, we need to upgrade CKEditor4 to 5th version. /cc @seanlip

[seanlip]

Makes sense, thanks. How hard would it be to do that -- is it as straightforward as changing the link in manifest.json? Are there instructions somewhere?

(Also, do you remember why we didn't use CKEditor5 when we upgraded the RTE? Was that because it wasn't out yet at the time, or was there some other reason? /cc @AllanYangZhou )

[bansalnitish]

No, it isn't this straightforward I guess. I tried doing that but I was getting error like:
CKEDITOR is not defined in app.js. I'll have to dig a bit deeper. Here is the complete documentation for the updgradation: https://ckeditor.com/docs/ckeditor5/latest/builds/guides/migrate.html.

I'm not sure as to why we didn't use CKEditor5.

Thanks!

[seanlip]

Chatted with @bansalnitish. He will have a go at updating to CKEditor5 to see whether any issues come up, and update this issue with the comments.

[bansalnitish]

Assigning this to @import-keshav, he's working on updating to CKEditor5.