Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization args normalization should be done before updation #6479

Open
DubeySandeep opened this issue Mar 19, 2019 · 0 comments
Open

Customization args normalization should be done before updation #6479

DubeySandeep opened this issue Mar 19, 2019 · 0 comments
Labels
code-health Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: High It's not clear what the solution is; will need investigation.

Comments

@DubeySandeep
Copy link
Member

DubeySandeep commented Mar 19, 2019

1. Normalization issue:

Currently, we directly use to update the customization args for interaction and the customization args go through the normalization process in the Interaction validation stage.

What should happen instead:
A validation method is only made for validation check not for changing the data, so this issue focus on moving the normalization process from validation to the update_interaction_customization_args i.e, normalization should be done while updating the customization args.

2. Setting default value to customization args:

Currently, we use to set the default value to the customization args when the customization_args dict is empty and then validates the customization args.

What should happen instead:
Remove setting the default value to customization arg and also remove this from the to_dict conversion method of InteractionInstance class.

@DubeySandeep DubeySandeep changed the title Customization args normalization should be done before updating Customization args normalization should be done before updation Mar 19, 2019
@DubeySandeep DubeySandeep added this to To do in Bug fixing team via automation Aug 14, 2019
@kevintab95 kevintab95 added this to Awaiting Triage in Learner and Creator Experience via automation Feb 2, 2020
@iamprayush iamprayush moved this from Awaiting Triage to Backend in Learner and Creator Experience Feb 15, 2020
@aks681 aks681 moved this from Backend to Low Priority in Learner and Creator Experience Feb 22, 2020
@nithusha21 nithusha21 removed this from To do in Bug fixing team Mar 4, 2020
@kevintab95 kevintab95 moved this from Low Priority to Interaction Issues in Learner and Creator Experience Aug 16, 2020
@kevintab95 kevintab95 added the bug Label to indicate an issue is a regression label Sep 1, 2022
@nithinrdy nithinrdy removed this from Interaction Issues (@iamprayush) in Learner and Creator Experience Oct 8, 2022
@Lawful2002 Lawful2002 added Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: High It's not clear what the solution is; will need investigation. and removed bug Label to indicate an issue is a regression labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-health Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: High It's not clear what the solution is; will need investigation.
Projects
Status: Todo
Development

No branches or pull requests

3 participants