Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use package.json for third-party libraries that are used in prod. #7061

Open
seanlip opened this issue Jul 1, 2019 · 1 comment
Open

Use package.json for third-party libraries that are used in prod. #7061

seanlip opened this issue Jul 1, 2019 · 1 comment
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@seanlip
Copy link
Member

seanlip commented Jul 1, 2019

(This suggestion was originally from @vojtechjelinek.)

We currently use a custom manifest.json file to manage our third-party production dependencies. However, in light of #7051 (thanks @kevinlee12!) it might be better to move these into package.json, so that we can get automated vulnerability alerts from running npm audit.

The aim of this issue is to investigate what would be needed to use package.json for our production dependencies, and develop an implementation strategy for doing this.

/cc @NishealJ @kevinlee12
@vojtechjelinek
Copy link
Member

vojtechjelinek commented Jul 7, 2019 •
edited

Just a snippet from Lighthouse best practices audit.

image

@kevinlee12 kevinlee12 added this to To Do (Low Priority) in Developer experience Aug 8, 2019
@kevintab95 kevintab95 added the enhancement Label to indicate an issue is a feature/improvement label Aug 30, 2022
@U8NWXD U8NWXD added Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed talk-to: @vojtechjelinek labels Sep 23, 2022
@seanlip seanlip removed this from To Do (Low Priority) in Developer experience Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Developer Workflow Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vojtechjelinek @seanlip @kevintab95 @U8NWXD