Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code for assigned voiceartist list in the opportunity model and language_codes_needing_voice_artists. #7376

Open
DubeySandeep opened this issue Aug 13, 2019 · 1 comment
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@DubeySandeep
Copy link
Member

Currently while creating an opportunity model we aren't populating the assigned_voice_artist_in_languages as there aren't any process of assigning voice artist. Once the voiceover application functionality is implemented change the opportunity model creation method such that it also populates the assigned_voice_artist_in_languages with the required data.

This will also remove the TODO tag used in the codebase here:

# TODO(DubeySandeep): Once the voiceover application functionality is
# implemented change this method such that it also populates the
# assigned_voice_artist_in_languages with the required data.

@seanlip
Copy link
Member

seanlip commented Sep 24, 2022

Adding a note from #13912 too: "Currently language_codes_needing_voice_artists in core/domain/opportunity_services.py is based off the translation status of written translations. This doesn't quite make sense for voiceovers."

As an update -- we should just get rid of these fields / dead code, since they are unneeded, as we are not going to be handling voiceovers through the contributor dashboard.

@seanlip seanlip changed the title Populate the assigned voiceartist list in the opportunity model once the voiceover application functionality is built. Remove dead code for assigned voiceartist list in the opportunity model and language_codes_needing_voice_artists. Sep 24, 2022
@seanlip seanlip removed this from P3 in Contributor Experience Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
Status: Todo
Development

No branches or pull requests

2 participants