Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor audio player services such that its can be used in other places #7928

Open
DubeySandeep opened this issue Nov 5, 2019 · 3 comments
Open

Refactor audio player services such that its can be used in other places #7928

DubeySandeep opened this issue Nov 5, 2019 · 3 comments
Labels
audio-translation Impact: Medium Will improve quality-of-life for at least 30% of users. Work: High It's not clear what the solution is; will need investigation.

Comments

@DubeySandeep
Copy link
Member

Currently, the AudioPlayerService depends on AudioTranslationManagerService, AssetsBackendApiService etc. We need to refactor the audio player service such that it is independent of other services so that the player services can be reused in other places.
@DubeySandeep DubeySandeep added this to Medium Priority Issues in Audio and translations [INACTIVE] Feb 25, 2020
@Vinit-Dantkale
Copy link
Contributor

Vinit-Dantkale commented Mar 4, 2020 •
edited

Hey, is this good issue to start? I think only loadAudio is being used from AssetsBackendApiService. Are you advising to reproduce same behaviour by making backend calls from audio-player.service.ts ?

@mzaman07
Copy link
Contributor

mzaman07 commented Mar 4, 2020

Hey @Vinit-Dantkale , yeah usually anything that is marked with Project-specific starter issue implies that it's good to start if you are new. As for more context related to this issue, I think it would be better to ask @DubeySandeep .

@Vinit-Dantkale Vinit-Dantkale self-assigned this Mar 4, 2020
@DubeySandeep
Copy link
Member Author

(Unassigned @Vinit-Dantkale as per discussion.)

@seanlip seanlip removed this from Medium Priority Issues in Audio and translations [INACTIVE] Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audio-translation Impact: Medium Will improve quality-of-life for at least 30% of users. Work: High It's not clear what the solution is; will need investigation.
Projects
LaCE Quality Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mzaman07 @seanlip @DubeySandeep @Vinit-Dantkale