Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiceovers Allowed for Untranslated Fields #8595

Open
U8NWXD opened this issue Feb 9, 2020 · 4 comments
Open

Voiceovers Allowed for Untranslated Fields #8595

U8NWXD opened this issue Feb 9, 2020 · 4 comments
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: High It's not clear what the solution is; will need investigation.

Comments

@U8NWXD
Copy link
Member

U8NWXD commented Feb 9, 2020

Describe the bug
Creators should not be able to upload voiceovers in language X for fields that have not yet been translated into language X. The modal says so, but allows uploads.

To Reproduce
Steps to reproduce the behavior:

  1. Create an exploration with some text field(s)
  2. Switch to the translation tab
  3. Make sure you are in voiceover moe
  4. Upload a voiceover for a language you did not write the exploration in and that does not have translations

Observed behavior
The upload is accepted, and the tab and card turn green to indicate voiceovers have been added, even though the modal says that translations are needed first.

Expected behavior
The upload should be rejected.

Screenshots

Screen Shot 2020-02-09 at 13 53 20

Desktop (please complete the following information; delete this section if the issue does not arise on desktop):

  • OS: macOS
  • Browser: Firefox
  • Version: release-2.9.0
@U8NWXD
Copy link
Member Author

U8NWXD commented Feb 9, 2020

I have reproduced this on Chrome also

@DubeySandeep
Copy link
Member

@U8NWXD, Currently the exploration is being completely managed by exploration editor, translators and voice artist. We haven't added any such validation of "Allowing voiceover only if translation exist." for conditions like translator/editor deleted original text/translation although the voiceover still exists.

In the future, the translation will be handled by the community and there will be less chance of this kinda issue to happen. I'm moving this to the "Translation and voiceover team", we will go through this issue.

@U8NWXD
Copy link
Member Author

U8NWXD commented Feb 11, 2020

@DubeySandeep the critical user paths document reads:

Try adding voiceovers for a different language. You should not be able to do so, without adding written translations for that language. The modal should tell you so.

I've left a suggested change to remove this row from the document since this validation is not yet performed

@nithusha21
Copy link
Contributor

Sounds good (regarding removing it from the testing doc). Note: Once this issue is fixed, please make sure you notify either Chris/me and we will add this back to the testing journey.

@DubeySandeep DubeySandeep added this to High Priority Issues in Audio and translations [INACTIVE] Mar 3, 2020
@seanlip seanlip removed this from High Priority Issues in Audio and translations [INACTIVE] Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: High It's not clear what the solution is; will need investigation.
Projects
Status: Todo
Development

No branches or pull requests

3 participants