Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cache messages after accepting or rejecting the suggestion #8678

Open
nishantwrp opened this issue Feb 19, 2020 · 7 comments
Open
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@nishantwrp
Copy link
Contributor

nishantwrp commented Feb 19, 2020

Update the cache messages after accepting or rejecting the suggestion instead of fetching it everytime. Refer #8624

@abhayraghuwanshi
Copy link
Contributor

abhayraghuwanshi commented Mar 10, 2020

@nishantwrp Is this the thing same as we do in the skill rights backend api service file as we post it and we cache it at the same time. When we fetch it from the backend if it is found in the cache we get it from there and if not found then we fetch it .
If this is the case i would like to work on this one

@nishantwrp
Copy link
Contributor Author

@abhayraghuwanshi Actually, the current scenario here is that when we accept or reject a suggestion we send the response of suggestion to the backend and we fetch the suggestion status again from backend to display the current status of the suggestion. Here, we can avoid fetching the suggestion status as we already know the response, we can directly update the cache.

@abhayraghuwanshi
Copy link
Contributor

@nishantwrp Is it a frontend issue as i saw some of the skills are caching in the backend too

@nishantwrp
Copy link
Contributor Author

@abhayraghuwanshi Yup, This is a frontend issue.

@abhayraghuwanshi abhayraghuwanshi self-assigned this Mar 10, 2020
@abhayraghuwanshi
Copy link
Contributor

@nishantwrp I am sorry to inform u that I couldn't work on this issue now as my other PRs have some major changes. If this is still free after a few days. I will surely take it

@abhayraghuwanshi abhayraghuwanshi removed their assignment Mar 14, 2020
@nishantwrp
Copy link
Contributor Author

@abhayraghuwanshi Ok, No Problem.

@ankita240796 ankita240796 added this to Awaiting Triage in Learner and Creator Experience via automation Mar 23, 2020
@kevintab95 kevintab95 moved this from Awaiting Triage to Editor Pages in Learner and Creator Experience Aug 18, 2020
@Showtim3 Showtim3 moved this from Editor Pages to Awaiting Triage in Learner and Creator Experience Aug 23, 2020
@Showtim3 Showtim3 moved this from Awaiting Triage to Editor Pages in Learner and Creator Experience Aug 23, 2020
@oppiabot
Copy link

oppiabot bot commented May 24, 2021

Hi @oppia/core-maintainers, this issue is not assigned to any project. Can you please update the same? Thanks!

@nithinrdy nithinrdy removed this from Editor Pages (@kevintab95) in Learner and Creator Experience Oct 3, 2022
@Lawful2002 Lawful2002 added bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

3 participants