Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code owner check for assigning code owner. #227

Closed
riyasingh1004 opened this issue Mar 26, 2021 · 4 comments
Closed

Update code owner check for assigning code owner. #227

riyasingh1004 opened this issue Mar 26, 2021 · 4 comments

Comments

@riyasingh1004
Copy link
Contributor

riyasingh1004 commented Mar 26, 2021

Currently, oppiabot gets the list of code owners from the list of requested reviewers.
Often this works, because GitHub automatically requests a review from the code owners but sometimes, the PR author would explicitly request a review from another contributor who isn't a code owner, and oppiabot will incorrectly assign the contributor as a code owner.

This issue aims at using the CODEOWNERS file from the oppia repository to get the appropriate code owners for the pull request based on the files changed.

The CODEOWNERS file can be found at https://github.com/oppia/oppia/blob/develop/.github/CODEOWNERS.

@vojtechjelinek
Copy link
Member

@jameesjohn Can you help here?

@jameesjohn
Copy link
Contributor

Done.

@vojtechjelinek
Copy link
Member

@jameesjohn I'm still a bit unsure what this issue exactly means? What is the problem with assigning reviewers as code owners even when they arent code owners?

@seanlip
Copy link
Member

seanlip commented Jan 6, 2023

I don't understand the problem here. Closing.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants