Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribute to foreign repositories via forks #137

Closed
Tracked by #134
samuelstroschein opened this issue Aug 27, 2022 · 2 comments
Closed
Tracked by #134

contribute to foreign repositories via forks #137

samuelstroschein opened this issue Aug 27, 2022 · 2 comments
Assignees
Labels
scope: inlang/fink-editor Related to source-code/website/editor. type: feature New feature or request

Comments

@samuelstroschein
Copy link
Member

samuelstroschein commented Aug 27, 2022

Contributing via OAuth flows (see #136) does not work for external contributors or repositories a translator has no access to. An alternative for public repositories could be GitHub's fork functionality. The editor forks a public repository either on behalf of the user or by creating an inlang-fork/repository fork for all external contributors.

More ideas are welcome.

@samuelstroschein samuelstroschein mentioned this issue Aug 27, 2022
6 tasks
@samuelstroschein samuelstroschein changed the title contribute to foreign repositories via forks (having no access to repositories but open pull requests) contribute to foreign repositories via forks Aug 27, 2022
@samuelstroschein samuelstroschein added scope: inlang/fink-editor Related to source-code/website/editor. type: feature New feature or request labels Aug 27, 2022
@samuelstroschein
Copy link
Member Author

The editor forking on behalf of the user seems to be the better flow. Changes from different users happen in isolation and forks are understood.

Flowchart

  1. Opening repository github.com/inlang/inlang in the editor.
  2. If a fork for the user does not exist, the user is notified via a dialog with explicit consent that the repository is forked.
    2.1. The fork has a prefix like inlang-{repositoryName} to identify the fork on encountering 2 again.
    2.2. The fork is auto-synced with upstream see the documentation and this documentation.
    2.3. The user conducts changes in the fork.
    2.4. Once the user is done, the user is forwarded to github to manually contribute the changes upstream.

Note: Potential conflict with hardcoded branch of #220

@samuelstroschein
Copy link
Member Author

closed with @255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: inlang/fink-editor Related to source-code/website/editor. type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants