Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update component api #2411

Merged
merged 5 commits into from
Mar 21, 2024
Merged

update component api #2411

merged 5 commits into from
Mar 21, 2024

Conversation

NilsJacobsen
Copy link
Member

@NilsJacobsen NilsJacobsen self-assigned this Mar 19, 2024
@linear Linear
Copy link

linear bot commented Mar 19, 2024

INLMC-22 Results after call

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5552dc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NilsJacobsen NilsJacobsen marked this pull request as draft March 19, 2024 17:02
@felixhaeberle
Copy link
Contributor

@NilsJacobsen ah I see you are still in the works of updating the API. afterwards, #2392 latest changes should work.

@NilsJacobsen
Merge remote-tracking branch 'origin/main' into nilsjacobsen/inlmc-22-…
c2732cf 
…results-after-call
@NilsJacobsen
feat: update api
5552dc5 
- removed dynamic imports to access schemas
- removed events (for now, let's see if we like the business logic in the component)
@NilsJacobsen NilsJacobsen marked this pull request as ready for review March 21, 2024 14:00
@NilsJacobsen NilsJacobsen merged commit d80d9e8 into main Mar 21, 2024
4 checks passed
@NilsJacobsen NilsJacobsen deleted the nilsjacobsen/inlmc-22-results-after-call branch March 21, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@NilsJacobsen NilsJacobsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NilsJacobsen @felixhaeberle