Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fink login #2813

Merged
merged 1 commit into from
May 27, 2024
Merged

fix fink login #2813

merged 1 commit into from
May 27, 2024

Conversation

janfjohannes
Copy link
Contributor

@janfjohannes janfjohannes commented May 23, 2024 •
edited

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 23, 2024 •
edited

⚠️ No Changeset found

Latest commit: 287ab8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced May 23, 2024
Closed
Merged
Closed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - opral-website PR #2813 May 23, 2024 17:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-website PR #2813 May 23, 2024 17:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - fink-editor PR #2813 May 23, 2024 17:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-manage PR #2813 May 23, 2024 17:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-manage PR #2813 May 23, 2024 17:23 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - fink-editor PR #2813 May 23, 2024 17:23 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-website PR #2813 May 23, 2024 17:23 — with Render Destroyed
@janfjohannes janfjohannes mentioned this pull request May 26, 2024
Open
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - badge-service PR #2813 May 27, 2024 00:03 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - git-proxy PR #2813 May 27, 2024 00:03 — with Render Destroyed
NiklasBuchfink
NiklasBuchfink requested changes May 27, 2024
View reviewed changes
Copy link
Member

@NiklasBuchfink NiklasBuchfink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The login issue is fixed now. I checked it again and there is no reloading issue anymore 👍

The website seems broken because of a window function in the LocalStorageProvider. I haven't found the critical part, but it should probably be included in "onMount" to make sure the window exists.

inlang/source-code/website/src/services/local-storage/src/LocalStorageProvider.tsx Outdated Show resolved Hide resolved
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - fink-editor PR #2813 May 27, 2024 12:51 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-website PR #2813 May 27, 2024 12:51 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-manage PR #2813 May 27, 2024 12:51 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - fink-editor PR #2813 May 27, 2024 12:53 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-website PR #2813 May 27, 2024 12:53 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to pr2813 - inlang-manage PR #2813 May 27, 2024 12:53 — with Render Destroyed
@janfjohannes janfjohannes merged commit 9004c08 into main May 27, 2024
6 checks passed
@janfjohannes janfjohannes deleted the pr2813 branch May 27, 2024 13:01
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NiklasBuchfink NiklasBuchfink NiklasBuchfink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janfjohannes @NiklasBuchfink @samuelstroschein