Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Error types that are part of the external api #2944

Conversation

LorisSigrist
Copy link
Member

@LorisSigrist LorisSigrist commented Jun 18, 2024

See: https://linear.app/opral/issue/MESDK-140/expose-error-types-that-are-part-of-the-external-api

Reviewers: If this change is ok for you you can merge this

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 8739851

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@inlang/sdk Patch
@inlang/badge Patch
@inlang/doc-layout-component Patch
@inlang/editor Patch
@inlang/github-lint-action Patch
vs-code-extension Patch
@inlang/message-bundle-component Patch
@inlang/rpc Patch
@inlang/settings-component Patch
@inlang/telemetry Patch
@inlang/cross-sell-ninja Patch
@inlang/plugin-i18next Patch
@inlang/plugin-json Patch
@inlang/plugin-m-function-matcher Patch
@inlang/plugin-next-intl Patch
@inlang/plugin-t-function-matcher Patch
@inlang/paraglide-unplugin Patch
@inlang/paraglide-js-e2e Patch
@inlang/paraglide-next-e2e Patch
@inlang/paraglide-rollup Patch
@inlang/paraglide-vite Patch
@inlang/paraglide-webpack Patch
@inlang/paraglide-astro Patch
@inlang/paraglide-sveltekit Patch
@inlang/paraglide-sveltekit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LorisSigrist LorisSigrist requested a review from jldec June 18, 2024 11:45
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @LorisSigrist
Small nit, I would prefer to list the exported error classes one by one in the index file instead of using * for readability and to avoid inadvertent exports in future. ( I can do it for you if you're busy with the react summit 😜 )

@jldec
Copy link
Contributor

jldec commented Jun 18, 2024

I will merge when CI is happy

@jldec jldec merged commit 4cf8e09 into main Jun 18, 2024
3 checks passed
@jldec jldec deleted the lorissigrist/mesdk-140-expose-error-types-that-are-part-of-the-external-api branch June 18, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants