-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-550: Upgrade to log4j2 2.23.1 #551
Conversation
e5ea0ec
to
fb79e8c
Compare
Upgrade log4j2 from 2.22.1 to 2.23.1. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
fb79e8c
to
3e89b52
Compare
Update log4j2 version in readme from 2.22.1 to 2.23.1 for 2.2.x branch. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
cd32203
to
b1096de
Compare
Did you check class updates in api bundle ? That's actually the most important to check for an update. |
True - unfortunately we have to shade some classes. See for example 54f2d59. I can do this next week. |
Yikes, there's a lot of changes in StatusLogger...:
|
Update log4j2 classes since 2.22.1 to 2.23.1. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
No no no no ;) If we just shade without changing, we wouldn't have to do it at all ;) You seem to have simply copied the sources and removed Pax Logging specific changes. Did you run the tests? (maybe they work? :) |
Thanks for your help. I will try to make it better next time. |
No worries - it's not something that can be done without spending a lot of time in Pax Logging ;) Thanks for the PR anyway. |
Upgrade log4j2 from 2.22.1 to 2.23.1.