Merge pull request #132 from dtsosie/pgsql-repl-keyword-fix

[COOK-4555] #127 Adding db user fails and replication support

libraries/provider_database_postgresql.rb

@@ -100,6 +100,16 @@ def exists?
           ret
         end
 
+        # Test if text is psql keyword
+        def keyword?(text)
+          begin
+            result = db('template1').exec_params('select * from pg_get_keywords() where word = $1', [text.downcase]).num_tuples != 0
+          ensure
+            close
+          end
+          result
+        end
+
         #
         # Specifying the database in the connection parameter for the postgres resource is not recommended.
         #

libraries/provider_database_postgresql_user.rb

@@ -42,7 +42,7 @@ def action_create
               options += " #{@new_resource.createdb ? 'CREATEDB' : 'NOCREATEDB'}"
               options += " #{@new_resource.createrole ? 'CREATEROLE' : 'NOCREATEROLE'}"
               options += " #{@new_resource.login ? 'LOGIN' : 'NOLOGIN'}"
-              options += " #{@new_resource.replication ? 'REPLICATION' : 'NOREPLICATION'}"
+              options += " #{@new_resource.replication ? 'REPLICATION' : 'NOREPLICATION'}" if keyword?('REPLICATION')
               options += " #{@new_resource.superuser ? 'SUPERUSER' : 'NOSUPERUSER'}"
 
               statement = "CREATE USER \"#{@new_resource.username}\""