Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOK-3322] Ohai plugin does not work with source install method #130

Closed
wants to merge 1 commit into from

Conversation

koseki
Copy link
Contributor

@koseki koseki commented Jul 10, 2013

http://tickets.opscode.com/browse/COOK-3322

source recipe rewrite node['nginx']['binary']

node.set['nginx']['binary']          = node['nginx']['source']['sbin_path']

and ohai_plugin use it,

  variables(
    :nginx_prefix => node['nginx']['source']['prefix'],
    :nginx_bin => node['nginx']['binary']
  )
status, stdout, stderr = run_command(:no_status_check => true, :cwd => "<%= @nginx_prefix %>", :command => "<%= @nginx_bin %> -V")

so nginx::source recipe must be included before nginx::ohai_plugin.

ohai_plugin didn't work with source install option.
source recipe rewrite node['nginx']['binary'] and ohai_plugin use it, so 'source' recipe must be included before 'ohai_plugin'.
@v1nc3ntlaw
Copy link

Nice work! Annoyed with recompile nginx every time if install from source.

@AaronO
Copy link

AaronO commented Aug 23, 2013

This works well for me 👍

What is preventing this from getting merged to the master ?

@jesseadams
Copy link

@koseki @v1nc3ntlaw @AaronO - Please collaborate in the ticket to get this merged in: http://tickets.opscode.com/browse/COOK-3322

@koseki
Copy link
Contributor Author

koseki commented Sep 10, 2013

I'll keep this pull request open, but #143 would be better than this.

Thank you, @zuazo ! 😄

@koseki koseki closed this Sep 19, 2013
@koseki
Copy link
Contributor Author

koseki commented Sep 19, 2013

Fixed by 436de98 and 05120c2 .

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants