Refine adding collaborators #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users should be able to add cookbook collaborators by searching for them by chef account username. This adds a new has_one association called chef_account then searches on that association using username.
This moves the add collaborators form into a modal which feels a bit more fluid then going to another page as it provides a bit more context for what you're adding collaborators to.
|
👍 |
|
Nice! 👍 |
tristanoneil
added a commit
that referenced
this pull request
Apr 23, 2014
Refine adding collaborators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍴 This makes two refinements to the add collaborators feature. Firstly it allows you to search by chef account usernames. Secondly it moves collaborators/new into a modal using the reveal ajax feature. The collaborators/new view felt a little sparse and lacked context. I think the form is simple enough to warrant moving it into a modal and it has more context now.