Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prefix is not reflected in the # HELP and # TYPE lines #21

Closed
JDA88 opened this issue Jun 1, 2023 · 2 comments
Closed

The prefix is not reflected in the # HELP and # TYPE lines #21

JDA88 opened this issue Jun 1, 2023 · 2 comments
Assignees

Comments

@JDA88
Copy link

JDA88 commented Jun 1, 2023

Describe the bug
When you use a prefix the # HELP and # TYPE lines in the generated metric file does not reflect it.
Effectively rendering those line inefectives

To Reproduce
Steps to reproduce the behavior:

  1. Use prefix: aci_
  2. Look at the generated files
# HELP health_ratio Returns health score
# TYPE health_ratio gauge
aci_health_ratio

Expected behavior
It should be:

# HELP aci_health_ratio Returns health score
# TYPE aci_health_ratio gauge
aci_health_ratio
thenodon added a commit that referenced this issue Jun 3, 2023
@thenodon thenodon self-assigned this Jun 3, 2023
@thenodon
Copy link
Member

thenodon commented Jun 3, 2023

@JDA88 thanks for the issue report. This is fixed in branch issue_22 so it can be tested with issue #22.

@thenodon thenodon closed this as completed Jun 6, 2023
@thenodon thenodon reopened this Jun 6, 2023
@thenodon
Copy link
Member

thenodon commented Jun 6, 2023

Merged in #27

@thenodon thenodon closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants