Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement concurrent requests call to the apic #3

Closed
thenodon opened this issue Aug 9, 2020 · 1 comment · Fixed by #4
Closed

Implement concurrent requests call to the apic #3

thenodon opened this issue Aug 9, 2020 · 1 comment · Fixed by #4
Assignees

Comments

@thenodon
Copy link
Member

thenodon commented Aug 9, 2020

Describe the solution you'd like
In the current implementation all requests to the ACI APIC is done sequentially. The scrape time will be the sum of all the requests. Instead goroutines should be used for each http request and the response returned on a channel(s). Depending on the parallelism of the machine the scrape time would be in the range of the time of the longest response time of all the request done to the APIC.

This will have a little effect on scrape time if the number of APIC queries are low, but will have a major effect on scrape time when the number increase and keep the scrape time more "constant" to a growing number of queries.

@thenodon thenodon self-assigned this Aug 9, 2020
@thenodon
Copy link
Member Author

thenodon commented Aug 9, 2020

with_go_routines
At 17:41 switch to use concurrent APIC request.

@thenodon thenodon linked a pull request Aug 10, 2020 that will close this issue
thenodon added a commit that referenced this issue Aug 10, 2020
* Update the bucket size to be more aligend to actual response time.

* Refactor using goroutines for every APIC api request [Issue #3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant