Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings component and extra settings #31

Merged
merged 3 commits into from
Jun 18, 2022

Conversation

FabioRosado
Copy link
Member

This PR adds a proper setting component which we can show when a user clicks the settings icon in the navbar. It also adds a few improvements and fixes for the websocket connector.

Here's what changed:

Websockets

  • Allow users to set a token in the settings, this will be used when we do the initial request (this feature is currently commented out due to CORS issue)
  • Fix issue where the client would still be shown as connected when we get an OnClose event which wasn't clean. The client will now disconnect and show as disconnected if we get an OnCloseWithError event. This will be the initial step towards implementing reconnection logic
  • Add connect/disconnect button on the Navbar without the need to change host/port
  • Send a stringified payload back to opsdroid so we can give opsdroid more information such as the name of the user that sent the message. This will stop opsdroid from replying with Hello None

User Settings

  • Allow users to specify their username in the settings
  • Send username when user sends message to opsdroid

Appearance

Here's how the settings look like at the moment:

Screenshot 2022-06-18 at 12 55 06

Closes #20

@FabioRosado FabioRosado merged commit 26f29bf into opsdroid:main Jun 18, 2022
@FabioRosado FabioRosado deleted the fr/settings branch June 18, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a proper settings component that can be toggled on/off
1 participant