Merge pull request #56 from jacobtomlinson/catch-skill-exceptions

Catch skill exceptions

opsdroid/core.py

@@ -131,11 +131,25 @@ def load_regex_skill(self, regex, skill):
 
     async def parse(self, message):
         """Parse a string against all skills."""
+        # pylint: disable=broad-except
+        # We want to catch all exceptions coming from a skill module and not
+        # halt the application. If a skill throws an exception it just doesn't
+        # give a response to the user, so an error response should be given.
         if message.text.strip() != "":
             logging.debug("Parsing input: " + message.text)
             for skill in self.skills:
                 if "regex" in skill:
                     regex = match(skill["regex"], message.text)
                     if regex:
                         message.regex = regex
-                        await skill["skill"](self, message)
+                        try:
+                            await skill["skill"](self, message)
+                        except Exception:
+                            await message.respond(
+                                "Whoops there has been an error")
+                            await message.respond(
+                                "Check the log for details")
+                            logging.exception("Exception when parsing '" +
+                                              message.text +
+                                              "' against skill '" +
+                                              skill["regex"] + "'")