Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Connector is logging an error which is not really an error #1910

Closed
chillipeper opened this issue May 5, 2022 · 0 comments · Fixed by #1911
Closed

Slack Connector is logging an error which is not really an error #1910

chillipeper opened this issue May 5, 2022 · 0 comments · Fixed by #1911

Comments

@chillipeper
Copy link
Contributor

chillipeper commented May 5, 2022

Description

Every time opsdroid responds in a thread for the slack connector, the log is throwing an error in the following form:

ERROR    Payload: {...} is not  implemented. Event wont be parsed

This is not really an error, but just a misplaced log message that should be a debug message.

The create_event method from the slack connector is returning an empty event. The event_handler checks that the event is not empty and throws the error, which should not be. If the event returns empty (which is valid) the event handler should not parse the event.

Since it's labeled as an error, every time there is a response in a thread from opsdroid, the ERROR is logged, which creates a lot of false entries in a production log.

Steps to Reproduce

Create a skill where opsdroid replies inside a thread

Expected Functionality

The error log should not appear as it's not really an error

Experienced Functionality

The logger is longing an ERROR message which is not really an error

Versions

  • 0.26:
@chillipeper chillipeper changed the title Opsdroid is logging Opsdroid is logging an error which is not really an error May 5, 2022
@chillipeper chillipeper changed the title Opsdroid is logging an error which is not really an error Slack Connector is logging an error which is not really an error May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant