Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error log and replace with debug log #1911

Merged
merged 1 commit into from May 14, 2022

Conversation

chillipeper
Copy link
Contributor

Description

Fixes #1910

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tests passing
  • locally tested in sample instance

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1911 (c2750c7) into master (33241f2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
- Coverage   99.35%   99.35%   -0.01%     
==========================================
  Files          83       83              
  Lines        5117     5116       -1     
==========================================
- Hits         5084     5083       -1     
  Misses         33       33              
Impacted Files Coverage Δ
opsdroid/connector/slack/connector.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33241f2...c2750c7. Read the comment docs.

@chillipeper chillipeper changed the title Remove error logging and replace with debug log Remove error log and replace with debug log May 6, 2022
Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@FabioRosado FabioRosado merged commit 2926657 into opsdroid:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack Connector is logging an error which is not really an error
2 participants