-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document parser configuration #477
Comments
U meant "it does not have a section on parsers"? |
Yes |
Hello! First time contributor here. Can I work on this one? |
Hello there @sbeesm it would be great if you could work on this issue, please let me know if you need help with anything! Also, welcome 😀👍 |
If I'm not wrong, parsers are being used to analyse the messages that the bot receives and the matcher matches it with the available skills and the bot replies accordingly. Very sorry but I am slightly confused about what exactly needs to be done and how to get started. |
Hi sbeesm The configuration reference doesn't have any info on how to configure the parsers. Each parser needs to be added with information on how to configure it. Also if you look at the documentation for each matcher you'll see that some have a configuration section, some don't. They all need one and it should be at the top too. |
The parsers have all the logic to connect to the NLU parsers network and parse the meaning of the words that a user typed in channel/to opsdroid. The matchers are used as decorators (check regex parser/matcher) and they are used to trigger the parser that connects to the NLU service. As for what needs to be done, Jacob beat me to it haha |
Thanks @jacobtomlinson and @FabioRosado for helping me get started. 😀 PR #382 fixes #353 and adds windows support but I still get this error when I try to run opsdroid in windows:
I have installed it using pip3 in anaconda in my default python 3.6 environment. |
In the test and example_config files, most of the parsers have configurations like name, access-token, min-score. And can u please tell me that how can I find more info on these configurations so that a proper documentation can be prepared. 🙏 |
At the moment you have different kinds of parsers in opsdroid:
All NLP parsers need to be specified in the file As Jacob said the configuration should be at the top of the document because this will be the most important piece of information that someone might need (you will care more about how to activate the parser first than how it works). I did a quick check and currently these are the parsers that don't have a configuration section:
The things with regex for example is that you don't really need any specific parameter in the Hope this was helpful 👍 |
Is this ok?
|
The always matcher parses every message as it is always working/running. So can the always matcher be configured or does it need to be configured? |
Yeah that looks good @sbeesm you can create a PR and start working on there if you wish to do so. |
Also, all the links to matchers under the 'Matchers available' section in Docs/tutorials/intoduction.md seem to be broken. They are not working. |
What are you using to read the documentation? The links work in the site and on my pycharm :) |
And shall I add a new Parsers section in the Configuration Reference or just add the missing configurations in their respective matcher docs? |
Is it only the wit.ai not working or all of them? |
All of them aren't working. |
Yes the links are not designed to work on the GitHub website, they are designed to work in the mkdocs documentation. |
(opsdroid#477) Adds a parsers section in the configuration reference.
Added/moved the configuration info to the starting of each matcher file.
I've created a PR #502 |
The configuration reference currently doesn't have a section on parsers. This should be added.
I also think each parser/matcher section should start with the configuration information for that parser, followed by the usage within a skill.
The text was updated successfully, but these errors were encountered: