Refactor connector opsdroid pointer

[jacobtomlinson]

Currently in the Connector class we expect opsdroid to pass a pointer to itself on connect and disconnect. This seems a little pointless as the connector should be storing the pointer as an attribute anyway.

Steps

• Add opsdroid as a kwarg in the __init__ method of the Connector class and store it as an attribute.
• Remove the opsdroid kwarg from the connect and disconnect method as they are no longer needed.
• All core connectors would also need updating to reflect this.

[zonagilreath]

I will try to work on this.

[zonagilreath]

This would be my first contribution to a project so I'm a little unsure of the protocol, should I also update the connector tests to reflect this change?

[FabioRosado]

Hello @zonagilreath welcome to the project!
You are correct, the tests will need to be updated as well otherwise they will fail as they will have opsdroid as a param.

Let us know if you need any help 👍

[FabioRosado]

Might be a good idea to add the opsdroid kwarg to the database class as well - this is related to the bug report of @colonelkrud

colonelkrud INFO opsdroid.core: Received stop signal, exiting. INFO opsdroid.core: Removing skills... 
INFO opsdroid.core: Stopping database ... 
ERROR opsdroid.core: Caught exception
ERROR opsdroid.core: {
'message': 'Task exception was never retrieved', 
'exception': TypeError('disconnect() takes 1 positional argument but 2 were given',), 
'future': <Task finished coro=<OpsDroid.handle_signal() done, defined at /usr/local/lib/python3.6/dist-packages/opsdroid/core.py:120>
 exception=TypeError('disconnect() takes 1 positional argument but 2 were given',)>}

[jacobtomlinson]

Yes!

[zonagilreath]

Sounds good, I'll checkout the db class once I get the connector tests fixed.

[zonagilreath]

Oh also, since the issue said "Add opsdroid as a kwarg" I'm adding it as a keyword-only arg and it won't be possible to supply it positionally. Is this what is desired?