Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #725 Refactor connector opsdroid pointer #726

Closed
wants to merge 3 commits into from

Conversation

zonagilreath
Copy link
Contributor

@zonagilreath zonagilreath commented Nov 6, 2018

Description

re: Issue #725 I refactored the Connector classes to take a pointer to the OpsDroid object at initialization, instead of when calling Connector.connect() and .disconnect()

Fixes #725

Status

READY

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (possibly, although I changed the method docstrings along the way)

How Has This Been Tested?

Passing all tests through Tox

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have updated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #726 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #726   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines        1719   1714    -5     
=====================================
- Hits         1719   1714    -5
Impacted Files Coverage Δ
opsdroid/connector/facebook/__init__.py 100% <100%> (ø) ⬆️
opsdroid/connector/slack/__init__.py 100% <100%> (ø) ⬆️
opsdroid/connector/rocketchat/__init__.py 100% <100%> (ø) ⬆️
opsdroid/connector/websocket/__init__.py 100% <100%> (ø) ⬆️
opsdroid/connector/telegram/__init__.py 100% <100%> (ø) ⬆️
opsdroid/connector/__init__.py 100% <100%> (ø) ⬆️
opsdroid/core.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842a5c3...2c48505. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor connector opsdroid pointer
1 participant