Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support providing an access token in the configuration for the matrix connector rather than the password #813

Closed
Cadair opened this issue Jan 18, 2019 · 6 comments · Fixed by colonelkrud/opsdroid#1 or #1707

Comments

@Cadair
Copy link
Contributor

Cadair commented Jan 18, 2019

This would alleviate the need to plain text the password in the config, and the access token can be deactivated. This would be a case of detecting the key in the config and skipping the login call

@FabioRosado
Copy link
Member

Could you create a PR with the changes that have been merged into your fork? Seems like a nice thing to add 😄

@Cadair
Copy link
Contributor Author

Cadair commented May 16, 2019

There is / was one

@FabioRosado
Copy link
Member

Erm... yeah you are right! Ignore me 😬

@jacobtomlinson
Copy link
Member

Would be good to get some progress on that. Looks like the change is done, just needs tests and docs.

@FabioRosado
Copy link
Member

I am going to write tests for it and docs. Will create a PR later today hopefully 😄

@FabioRosado
Copy link
Member

Just submitted a PR. Tox showed that the coverage was 100% hopefully it will work and we can merge the PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment