New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to login to the Matrix connector with an access_token #1707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push something in an hour ish with my suggestions. my comments were for PR #1706. Changes pushed there.
0bc2259
to
d36a0fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
==========================================
- Coverage 99.54% 99.42% -0.12%
==========================================
Files 71 71
Lines 4176 4196 +20
==========================================
+ Hits 4157 4172 +15
- Misses 19 24 +5
Continue to review full report at Codecov.
|
(lint fails here would be fixed by #1709 ) |
9ef84e6
to
359a1c6
Compare
opsdroid/connector/matrix/tests/responses/single_message_sync.json
Outdated
Show resolved
Hide resolved
addaf75
to
61c6ec5
Compare
This now also adds support to the external api server to track multiple calls against the same route with different methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test infra changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing useful to add really, looks good 👍
status, response = self.responses[route].pop(0) | ||
method = request.method | ||
|
||
self._calls[(route, method)].append(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume making this key a tuple instead of just route doesn't break a bunch of stuff downstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed all the things it broke 😀
Description
This adds support for configuring the matrix connector with an access_token.
Fixes #813
It also adds the first matrix connector tests using the framework in #1558 and #1706 (so it is based on #1706)
Status
*UNDER DEVELOPMENT
Type of change
How Has This Been Tested?
I need to test this IRL.
Checklist: