Make load and start_connectors async #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This looks like it would make things easier. |
Cadair
approved these changes
Sep 23, 2019
SolarDrew
approved these changes
Sep 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #1072 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 40 40
Lines 2450 2450
=======================================
Hits 2440 2440
Misses 10 10
Continue to review full report at Codecov.
|
jacobtomlinson
pushed a commit
that referenced
this pull request
Sep 24, 2019
* Updating readme with docker swarm/compose example * Adding openssh-client to dockerfile, adding key_path as a skill parameter * test_install_specific_remote_module required None type on git_clone call * test attempt * reworking * adding None type to test_instalL-default_remote_module * running black * Update aiohttp from 3.6.0 to 3.6.1 (#1066) * Update webexteamssdk from 1.1.1 to 1.2 (#1067) * Add flake8 to the precommit hooks (#1073) * Make load and start_connectors async (#1072) * Make load async * Add missing docstring * Undo wrapping config path in string * Test git clone ssh rsa path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
opsdroid.OpsDroid.loadandopsdroid.OpsDroid.start_connectorsasync. This makes it easier to block on connector startup from withinstart_connectors.Status
READY