Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make no-cache the default for local skills #1244

Merged

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Nov 6, 2019

Description

Change the loader so that if a module is installed from a path rather than a repo or gist it will be assumed to have no-cache: true.

Fixes #654

Status

READY

Type of change

  • Config defaults change

How Has This Been Tested?

Added unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1244   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2611    2616    +5     
======================================
+ Hits         2611    2616    +5
Impacted Files Coverage Δ
opsdroid/loader.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644978a...c86c8b9. Read the comment docs.

Copy link
Contributor

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Please yes!

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm happy with it as well 👍

@FabioRosado FabioRosado merged commit 08bdd2a into opsdroid:master Nov 6, 2019
@jacobtomlinson jacobtomlinson deleted the no-cache-default-for-path branch November 6, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat skills with explicit path as local
3 participants