Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Documentation with Fixed Grammar Mistakes #1284

Merged
merged 6 commits into from
Dec 2, 2019

Conversation

ShahrukhYousafzai
Copy link
Contributor

@ShahrukhYousafzai ShahrukhYousafzai commented Dec 2, 2019

Description

Improved documentation with fixed grammar mistakes to make documentation more easy to understand.

Status

READY

Type of change

  • Documentation (fix or adds documentation)

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1284   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          51      51           
  Lines        2775    2775           
======================================
  Hits         2775    2775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b35169...71fb471. Read the comment docs.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this pull request and welcome to open source.

I've made a couple of review comments that I would like you to address before we can get this merged. Let me know if you need any help with the review process.

docs/configuration.md Show resolved Hide resolved
docs/overview.md Outdated Show resolved Hide resolved
docs/overview.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ShahrukhYousafzai ShahrukhYousafzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check now :)

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes.

I'm going to merge this PR as it's in a good state. However please note that these have been some extremely small changes and many projects would not consider reviewing a contribution like this. In future please make more substantial changes that add more value to the project.

We love to thank contributors by sending them opsdroid stickers! Fill in the claim form to get yours!

@jacobtomlinson jacobtomlinson merged commit 9ddcb55 into opsdroid:master Dec 2, 2019
@ShahrukhYousafzai
Copy link
Contributor Author

Okay, thanks!
I'll keep that in Mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants