Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated connector documentation #1461

Merged
merged 1 commit into from May 10, 2020
Merged

Fix outdated connector documentation #1461

merged 1 commit into from May 10, 2020

Conversation

HalflingWizard
Copy link

Description

I tried to fix the outdated Document issue. this is my first serious contribution. I'm not totally sure if I did it right.

Fixes #1423

Status

READY

Type of change

  • Documentation (fix or adds documentation)

How Has This Been Tested?

I didn't test, I just changed the doc according to opsdroid.connector.init.py

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #1461 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1461   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          52       52           
  Lines        3168     3168           
=======================================
  Hits         3165     3165           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0cba3...484e4af. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great work! Thank you so much @iammamad for taking the time to fix this issue with our docs!

@FabioRosado FabioRosado merged commit cd04673 into opsdroid:master May 10, 2020
@jacobtomlinson jacobtomlinson changed the title I tried to fix outdated Documentation Fix outdated connector documentation May 14, 2020
@HalflingWizard HalflingWizard deleted the FixOutdatedDocumantation branch August 11, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix outdated documentation - Creating a custom connector
2 participants