Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom config path being ignored during reload #1476

Merged
merged 2 commits into from May 15, 2020

Conversation

jacobtomlinson
Copy link
Member

When opsdroid reloads it also reloads its config. Currently this is loaded from the default paths even if a custom path was passed in as a cli argument.

This PR passes any custom paths through to opsdroid for use when reloading.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1476 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          52       52           
  Lines        3184     3186    +2     
=======================================
+ Hits         3181     3183    +2     
  Misses          3        3           
Impacted Files Coverage Δ
opsdroid/cli/start.py 100.00% <100.00%> (ø)
opsdroid/core.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092b2bf...a3953ab. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit 47efe84 into opsdroid:master May 15, 2020
@jacobtomlinson jacobtomlinson deleted the reload-custom-cfg-path branch May 15, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant