Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sqlite database location config option to 'path' to match other config #1481

Merged
merged 1 commit into from May 18, 2020

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented May 17, 2020

I noticed that the sqlite database has a config option file to set where the database is, but other options such as skills use the key path to set where something is.

This PR updates the sqlite database to use path but also includes file as an alias with a deprecation warning.

Status

READY

How Has This Been Tested?

  • Updated unit tests to use new path option
  • Added unit test for old file option to ensure backward compatibility

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #1481 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          52       52           
  Lines        3280     3281    +1     
=======================================
+ Hits         3277     3278    +1     
  Misses          3        3           
Impacted Files Coverage Δ
opsdroid/database/sqlite/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1041c0...709edf6. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit 962ad80 into opsdroid:master May 18, 2020
@jacobtomlinson jacobtomlinson deleted the update-sqlite-config branch May 18, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant