Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webex teams config #1504

Merged
merged 2 commits into from May 26, 2020
Merged

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented May 26, 2020

Description

Looks like there was a bug in the voluptuous config for the WebEx Teams connector. The URL option is a function and needs to be called.

https://github.com/alecthomas/voluptuous#urls

Fixes #1501

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Added unit test

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1504 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1504   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          52       52           
  Lines        3296     3296           
=======================================
  Hits         3293     3293           
  Misses          3        3           
Impacted Files Coverage Δ
opsdroid/connector/webexteams/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c38ffc...1aacde6. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit 4bb2f85 into opsdroid:master May 26, 2020
@jacobtomlinson jacobtomlinson deleted the fix-webex-teams branch May 26, 2020 21:21
FabioRosado pushed a commit to FabioRosado/opsdroid that referenced this pull request Jun 25, 2020
* Fix webex teams config

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco WebEx Teams connector doesn't start
1 participant