Fix matrix connector sync_token book keeping and log on successful connect #1752
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
==========================================
- Coverage 99.32% 99.32% -0.01%
==========================================
Files 75 75
Lines 4414 4412 -2
==========================================
- Hits 4384 4382 -2
Misses 30 30
Continue to review full report at Codecov.
|
4 tasks
chillipeper
added a commit
to chillipeper/opsdroid
that referenced
this pull request
Mar 9, 2021
This reverts commit fb36f5c.
jacobtomlinson
added a commit
that referenced
this pull request
Apr 2, 2021
… mode (#1749) * first refactor version for slack events api * first refactor version for slack events api * black linting * pass flake8 * Add lint corrections * Add black lint * Remove unused attribute * Add Documentation * first refactor version for slack events api * first refactor version for slack events api * black linting * pass flake8 * Add lint corrections * Add black lint * Remove unused attribute * Add Documentation * Add socket mode backend * Add Documentation * Add handle bot message subtype * Fix bug when parsing events * Add tests to handle bot message subtype * Drop classes in tests * Drop classes in tests * Adding fixes to connector * Fixes to documentation * Inform users that RTM support has been dropped. socket-mode support defaults to true * Remove explicit event types from connector * Fix black formatting * make bot-token required instead of token. remove Inclusive from base_schema, not needed * Update docs * Fix tests for bot-token changes * replace caplog messages for caplog test * Revert "Fix matrix connector sync_token bookkeeping (#1752)" This reverts commit fb36f5c. * Add missing test * Remove unnecesary Logger line * Fix documentation Co-authored-by: Jacob Tomlinson <jacobtomlinson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the matrix connector error out cleaner if it can't connect to the HS
Status
READY
Type of change