Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to Message constructor in Mattermost connector #1774

Merged
merged 2 commits into from May 23, 2021

Conversation

davdr
Copy link
Contributor

@davdr davdr commented May 13, 2021

In #1116 the user_id arg was added to all events, and the event constructors were updated to use kwargs. However the Mattermost connector was missed and so the positional arguments are now broken.

This PR switches the Mattermost connector to use kwargs instead.

Fixes #1773

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #1774 (00ecc34) into master (bd61d9a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1774   +/-   ##
=======================================
  Coverage   99.27%   99.28%           
=======================================
  Files          78       78           
  Lines        4583     4584    +1     
=======================================
+ Hits         4550     4551    +1     
  Misses         33       33           
Impacted Files Coverage Δ
opsdroid/connector/mattermost/__init__.py 100.00% <ø> (ø)
opsdroid/connector/slack/connector.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd61d9a...00ecc34. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @davdr apologies for the delay in reviewing this PR. This looks good, but it seems there are some linting issues. Are you able to fix them with black?

@davdr
Copy link
Contributor Author

davdr commented May 23, 2021

Thanks @FabioRosado -- should be okay now.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the lint issues, the text failure seems a bit weird but isn't related to this PR so I'm accepting it and merging it.

Also thank you for creating the issue and fixing it 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mattermost connector is broken
3 participants